-
Notifications
You must be signed in to change notification settings - Fork 6
Cleanup of obsolete extended tracking code #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: L1TK-dev-15_1_0_pre4
Are you sure you want to change the base?
Conversation
d50a7f6 to
8b60d2e
Compare
tomalin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK to me, but I suggest @sarafiorendi checks it too before we merged it.
|
N.B.: I just found two orphan method declarations in Sector.h that no longer have a corresponding definition in Sector.cc, so I removed these in c74d45b. |
|
I'm happy with the PR, just wondering if we shouldn't also remove these lines cmssw/L1Trigger/TrackFindingTracklet/src/TrackletProcessorDisplaced.cc Lines 75 to 103 in c74d45b
? |
When I try commenting out these lines, I get the following error: This is because the TPDs still write out projections, unlike the TPs: cmssw/L1Trigger/TrackFindingTracklet/src/TrackletConfigBuilder.cc Lines 712 to 722 in 9db4e13
At some point, we'll need to update |
PR description:
While preparing cms-sw#49779, I realized there are still a couple artifacts from before the TrackletEngineDisplaced, TripletEngine, and TrackletCalculatorDisplaced were combined into the TrackletProcessorDisplaced. So this PR:
PR validation:
Since the current wiring makes no reference to the TrackletCalculatorDisplaced or the StubTripletsMemory there is no change to the behavior of the extended tracking emulation, and the code compiles and runs as before.